Fix bug #1782, forbidden chars in ID PATCH v2 #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| OrionError oe(SccBadRequest, "invalid character in URI"); | ||
| return oe.render(ciP, ""); | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems like something that should be done for all v2 requests (perhaps v1 also),
not only PATCH /v2/entities/{eid} ...
Should the check be on a higher level?
Somewhere in rest.cpp ...
There was a problem hiding this comment.
Ah, it's only about the ID, not the whole path ...
NTC
There was a problem hiding this comment.
I'll check other 'paths' with ID for this point. If any is found, we can create an issue for all them and solve them in the same PR ...
|
LGTM |
| @@ -16,3 +16,5 @@ | |||
| - Add: type param for POST entity in v2 (Issue #982, #984) | |||
| - Add: support for geo:point type as a way of specifying location attribute in NGSIv2 (Issue #1038) | |||
| - Add: type param for PUT entity in v2 (Issue #988, #992, #1000) | |||
| - Fix: not detecting forbidden chars in ID for PATH v2 (Issue #1782) | |||
There was a problem hiding this comment.
in ID -> in entityID ?
PATH -> PATCH ?
|
LGTM |
fgalan
pushed a commit
that referenced
this pull request
Feb 12, 2016
…_uri_patch Fix bug #1782, forbidden chars in ID PATCH v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #1782, forbidden chars in ID PATCH v2
@kzangeli
@fgalan